Skip to content

Fix PHP 8.1 deprecation #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2021
Merged

Fix PHP 8.1 deprecation #93

merged 1 commit into from
Dec 1, 2021

Conversation

enumag
Copy link
Contributor

@enumag enumag commented Oct 1, 2021

Closes #92

@bsweeney bsweeney added this to the 0.5.3 milestone Oct 1, 2021
@mondrake mondrake mentioned this pull request Oct 2, 2021
Merged
@mondrake
Copy link
Contributor

mondrake commented Oct 2, 2021

Unfortunately, I do not think this will be sufficient for PHP 8.1.

I suggest to merge #94 first and then add testing on GH to spot any other deprecation.

@enumag
Copy link
Contributor Author

enumag commented Oct 2, 2021

Yeah I'm not sure it's enough for 8.1 support, I just fixed the error from #92. It would be best to have your PR merged first and then rebase this.

@bsweeney bsweeney merged commit b01a8d7 into dompdf:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsweeney bsweeney bsweeney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.3
Development

Successfully merging this pull request may close these issues.

PHP 8.1 support
3 participants
@enumag @mondrake @bsweeney